[Java-Spring] Enable bean validation for `spring-http-interface` when configured by thiswasdumb · Pull Request #23609 · OpenAPITools/openapi-generator

thiswasdumb · 2026-04-23T22:40:26Z

Description

The current logic for spring-http-interface always sets useBeanValidation and performBeanValidation to false, which serves problematic when fields are expected to not be nullable. This ensures that if they are set to true, the generated classes contain the @NotNull generation alongside those variables.

This MR will fix #23585

Changes

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java I removed the logic which always sets them to false and follows through with setting them based on their expected value.
modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java tests to ensure the file is generated as expected

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package || exit
./bin/generate-samples.sh ./bin/configs/*.yaml || exit
./bin/utils/export_docs_generators.sh || exit
```
(For Windows users, please run the script in WSL)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Enable bean validation in spring-http-interface when useBeanValidation and performBeanValidation are enabled. Generates @NotNull for required fields and applies @Valid to collection elements and request body lists. Fixes #23585.

Bug Fixes
- Respect useBeanValidation/performBeanValidation instead of forcing false; parse boolean or string values and default to false when unset; removed forced writePropertyBack(USE_BEANVALIDATION, false).
- Update the warning to only disable documentationProvider and annotationLibrary; keep useJakartaEe defaulted to true.
- Add a unit test verifying @NotNull generation when both flags are true; regenerate samples to add List<@Valid ...> and nested collection @Valid across variants.

^{Written for commit 4888232. Summary will update on new commits. Review in cubic}

…ted for objects containing required fields

thiswasdumb · 2026-04-23T22:43:46Z

I'd feel bad pinging because it is such a small change... I just saw the issue and wanted to give a go at addressing it honestly.

cubic-dev-ai

No issues found across 2 files

wing328 · 2026-04-24T08:08:58Z

thanks for the PR

please follow step 3 to update the samples to address https://github.com/OpenAPITools/openapi-generator/actions/runs/24862461150/job/72791337954?pr=23609

thiswasdumb · 2026-04-24T10:01:42Z

thanks for the PR

please follow step 3 to update the samples to address https://github.com/OpenAPITools/openapi-generator/actions/runs/24862461150/job/72791337954?pr=23609

Yep sorry I had like 176 files edited when I compiled so I thought I was definitely not doing it right. Was gonna take a look at the errors in the pipeline to know wha to upload, will do this when I get home. Thank you so much for the link!!

thiswasdumb · 2026-04-24T21:35:08Z

Added the samples now 👍

wing328 · 2026-04-27T08:49:21Z

please review the build failure when you've time.

Co-authored-by: Copilot <copilot@github.com>

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java">

<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java:433">
P2: Post-super `containsKey` check can misclassify defaulted `useBeanValidation` as user-specified, preventing intended spring-http-interface defaults.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

Co-authored-by: Copilot <copilot@github.com>

thiswasdumb · 2026-04-27T23:37:35Z

I am having issues with spring-http-interface-springboot-4 not generating the jakarta.validation.Valid import while all others are, so I will need to look into this more tomorrow (just leaving this note for now)

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java">

<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java:436">
P1: Null-unsafe parsing of bean-validation options can throw NPE when properties are not present in additionalProperties.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-04-27T23:41:38Z

+
+            if (configOptions.stream().noneMatch(opt -> USE_BEANVALIDATION.equals(opt.getLeft()))) {
+                Object val = additionalProperties.get(USE_BEANVALIDATION);
+                useBeanValidation = val instanceof Boolean ? (Boolean) val : Boolean.parseBoolean(val.toString());


P1: Null-unsafe parsing of bean-validation options can throw NPE when properties are not present in additionalProperties.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java, line 436: <comment>Null-unsafe parsing of bean-validation options can throw NPE when properties are not present in additionalProperties.</comment> <file context> @@ -430,25 +430,14 @@ public void processOpts() { + + if (configOptions.stream().noneMatch(opt -> USE_BEANVALIDATION.equals(opt.getLeft()))) { + Object val = additionalProperties.get(USE_BEANVALIDATION); + useBeanValidation = val instanceof Boolean ? (Boolean) val : Boolean.parseBoolean(val.toString()); } - if (!additionalProperties.containsKey(PERFORM_BEANVALIDATION)) { </file context>

Adding logic and verifying with test which ensures @NotNull is genera…

c4123c0

…ted for objects containing required fields

thiswasdumb changed the title ~~[Java-Spring] Fixing Logic to Ensure useBeanValidation Is Set to True When Expected~~ [Java-Spring] Enable bean validation for spring-http-interface when configured Apr 23, 2026

cubic-dev-ai Bot reviewed Apr 23, 2026

View reviewed changes

wing328 added Issue: Bug Server: Java Server: Spring labels Apr 24, 2026

wing328 added this to the 7.22.0 milestone Apr 24, 2026

Adding samples for pipeline

c9ede04

thiswasdumb and others added 2 commits April 28, 2026 00:16

Updating error in build due to forced bean setting

820dfc3

Trying to fix by setting as expected

ca60f58

Co-authored-by: Copilot <copilot@github.com>

cubic-dev-ai Bot reviewed Apr 27, 2026

View reviewed changes

Comment thread modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java Outdated

Addressing comment

4888232

Co-authored-by: Copilot <copilot@github.com>

cubic-dev-ai Bot reviewed Apr 27, 2026

View reviewed changes

wing328 modified the milestones: 7.22.0, 7.23.0 Apr 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Java-Spring] Enable bean validation for `spring-http-interface` when configured#23609

[Java-Spring] Enable bean validation for `spring-http-interface` when configured#23609
thiswasdumb wants to merge 5 commits intoOpenAPITools:masterfrom
thiswasdumb:spring-http-useBean

thiswasdumb commented Apr 23, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

thiswasdumb commented Apr 23, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

wing328 commented Apr 24, 2026

Uh oh!

thiswasdumb commented Apr 24, 2026

Uh oh!

thiswasdumb commented Apr 24, 2026

Uh oh!

wing328 commented Apr 27, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

thiswasdumb commented Apr 27, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot Apr 27, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

thiswasdumb commented Apr 23, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

PR checklist

Summary by cubic

Uh oh!

thiswasdumb commented Apr 23, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

wing328 commented Apr 24, 2026

Uh oh!

thiswasdumb commented Apr 24, 2026

Uh oh!

thiswasdumb commented Apr 24, 2026

Uh oh!

wing328 commented Apr 27, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thiswasdumb commented Apr 27, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thiswasdumb commented Apr 23, 2026 •

edited by cubic-dev-ai Bot

Loading

cubic-dev-ai Bot Apr 27, 2026 •

edited

Loading